From 76a389f52d3e1f31e58801ab79f3219815b3cd2e Mon Sep 17 00:00:00 2001
From: Stefan Koelle <50440224+skoelle@users.noreply.github.com>
Date: Sun, 9 Aug 2026 11:57:06 +0200
Subject: [PATCH] install.sh: prevent silent abort from pipefail in tag_name
 extraction, add diagnostics

---
 install.sh | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/install.sh b/install.sh
index 368fa35..d3020e9 100644
--- a/install.sh
+++ b/install.sh
@@ -43,7 +43,9 @@ release_json="$(curl -sSL "https://api.github.com/repos/${REPO}/releases/latest"
   exit 1
 }
 
-if echo "$release_json" | grep -q '"message":[[:space:]]*"Not Found"'; then
+echo "Received ${#release_json} bytes from the GitHub API."
+
+if echo "$release_json" | grep -q '"message"[[:space:]]*:[[:space:]]*"Not Found"'; then
   echo "" >&2
   echo "Could not find a published release for ${REPO}." >&2
   echo "This usually means no release has been tagged yet." >&2
@@ -59,20 +61,26 @@ if echo "$release_json" | grep -q '"message":[[:space:]]*"Not Found"'; then
   exit 1
 fi
 
-if echo "$release_json" | grep -qi 'API rate limit exceeded'; then
+if echo "$release_json" | grep -qi 'rate limit exceeded'; then
   echo "GitHub API rate limit exceeded. Wait a bit and try again, or authenticate with a GitHub token." >&2
   exit 1
 fi
 
-latest_tag="$(echo "$release_json" | grep -m1 '"tag_name"' | sed -E 's/.*"([^"]+)".*/\1/')"
+# Note: '|| true' below prevents 'set -o pipefail' + 'set -e' from aborting the
+# script silently if grep finds no match; the emptiness check right after
+# gives a proper diagnostic instead.
+latest_tag="$(echo "$release_json" | grep -m1 '"tag_name"' | sed -E 's/.*"tag_name"[[:space:]]*:[[:space:]]*"([^"]+)".*/\1/')" || true
 
 if [ -z "$latest_tag" ]; then
   echo "Could not parse the latest release tag from the GitHub API response." >&2
   echo "Raw response (truncated):" >&2
-  echo "$release_json" | head -c 500 >&2
+  echo "$release_json" | head -c 800 >&2
+  echo "" >&2
   exit 1
 fi
 
+echo "Latest release tag: ${latest_tag}"
+
 asset="kctl-tui-${os}-${arch}"
 url="https://github.com/${REPO}/releases/download/${latest_tag}/${asset}"